Did sentence has some mistakes yet?

Question

I didn't know what are good music and voice until i heard her songs

Answer 1

最愛解答

This sentence is wrong in grammar.

I didn't know what was (we use “was” but not “are” because all you are talking about happened in the past) good music and voice until I heard her songs

In fact you should also change to : what good music and voice was, not what was good music and voice because this is not a direct question.

Therefore the final version is :

I didn’t know what good music and voice was until I heard her songs.

資料來源： Myself

Answer 2

ok